🟢 Good taste - Clean refactoring

Verdict: ✅ Merge it

Key insight: The different __getattr__ patterns (eager import in __init__.py, lazy in types.py) are intentional to avoid circular dependencies since marketplace.types imports from plugin.types. Good design.

Proper deprecation timeline (1.16→1.19), backward compatibility maintained, well-tested. No agent behavior changes, no eval impact.

QA Report: Marketplace Module Refactor

✅ PASS

Summary: The refactor successfully moves marketplace definitions to a new module with full backward compatibility and proper deprecation warnings.

Environment Setup

✅ Build successful

$ make build
Dependencies installed successfully.
Pre-commit hooks installed successfully.
Build complete! Development environment is ready.

CI & Test Status

✅ All critical CI checks passed:

• ✅ sdk-tests (2m14s)
• ✅ cross-tests (1m20s)
• ✅ Python API breakage checks (23s)
• ✅ REST API checks (32s)
• ✅ pre-commit (1m14s)
• ✅ agent-server-tests, tools-tests

✅ Local test results:

$ uv run pytest tests/sdk/marketplace/ -v
50 passed in 0.13s
  - 11 deprecation tests (new)
  - 39 marketplace functionality tests (moved from plugin/)

Functional Verification

1. Import Behavior ✅

Tested both new and old import paths to verify backward compatibility:

New import path (no warnings):

from openhands.sdk.marketplace import Marketplace, MarketplaceOwner, ...
✓ Imports successful with 0 warnings

Old import paths (deprecation warnings):

from openhands.sdk.plugin import Marketplace
✓ Imports successful with proper DeprecatedWarning:
  "Importing Marketplace from openhands.sdk.plugin is deprecated 
   as of 1.16.0 and will be removed in 1.19.0. Import from 
   openhands.sdk.marketplace instead."

Class identity verification:

Marketplace is OldMarketplace: True
MarketplaceOwner is OldMarketplaceOwner: True
✓ Both import paths return identical classes

2. Marketplace Functionality ✅

Verified all marketplace classes instantiate and function correctly:

# All classes work with new import location
owner = MarketplaceOwner(name="Test Team", email="test@example.com")
entry = MarketplaceEntry(name="test-skill", source="./skills/test")
plugin_entry = MarketplacePluginEntry(name="test-plugin", ...)
source = MarketplacePluginSource(source="github", repo="owner/repo")
metadata = MarketplaceMetadata(version="1.0.0")
✓ All classes instantiate correctly

3. Marketplace.load() Method ✅

Tested loading a real marketplace:

$ uv run python -c "from openhands.sdk.marketplace import Marketplace; ..."
Marketplace loaded successfully!
  Name: mixed-skills-marketplace
  Owner: OpenHands Team
  Skills: 2 skill(s)
  Plugins: 0 plugin(s)
✓ Marketplace loading works correctly

4. Example Integration ✅

Verified the updated example runs without errors:

$ cd examples/01_standalone_sdk/43_mixed_marketplace_skills
$ uv run python main.py --list
Installed Skills
No skills installed.
EXAMPLE_COST: 0
✓ Example runs successfully with new import path

5. Skills Module Integration ✅

Verified internal SDK code that uses marketplace works:

$ uv run pytest tests/sdk/skills/test_installed_skills.py -k marketplace -v
5 passed
  - test_install_local_skills
  - test_install_skills_force_overwrite
  - test_install_handles_missing_skill_source
  - test_install_skills_from_plugin_directories
  - test_install_both_standalone_and_plugin_skills
✓ Skills integration with marketplace works correctly

Verification Summary

✅ All changed behavior verified:

1. New module openhands.sdk.marketplace contains all marketplace types
2. Old import paths continue to work with deprecation warnings
3. Deprecation warnings properly reference version 1.16.0 (deprecated) and 1.19.0 (removal)
4. All marketplace functionality preserved
5. Example code updated and functional
6. Internal SDK code updated and functional
7. No breaking changes to public API
8. All tests pass (50 marketplace tests + 212 plugin tests + 5 skills integration tests)

Migration Path Verification ✅

The PR provides a clear migration path:

Before (deprecated but still works):

from openhands.sdk.plugin import Marketplace

After (recommended):

from openhands.sdk.marketplace import Marketplace

Users have 3 minor versions (1.16.0 → 1.19.0) to migrate.

Verdict

✅ PASS - This is a clean refactor that:

• Improves code organization by separating marketplace from plugin concerns
• Maintains full backward compatibility with deprecation warnings
• Provides a clear migration path with 3-version runway
• Preserves all functionality
• Updates all internal references
• Includes comprehensive test coverage

No issues found. Ready for merge.

I think it's nice that we use them for skills, I don't know what the plugin format will become, it feels a bit... fluid. But skills are so important and widespread that it's nice to use/reuse a bucket of them IMHO.